Repository navigation
[DOCS] Explain what testmon's "no tests ran" means - #772
Open
Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Open
Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Conversation
make check and make test select tests with pytest-testmon, so on a tree whose code has already passed they print "no tests ran" and exit 0. That reads as a skipped suite to anyone unfamiliar with testmon. Say what it means, and point at make test-all for data-only changes testmon can't see. Signed-off-by: Seth Fitzsimmons <seth@mojodna.net>
Seth Fitzsimmons (sethfitz)
added
the
change type - documentation - member 📝
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make checkandmake testselect tests with pytest-testmon, so on a tree whose code has already passed they printno tests ranand exit 0. Someone unfamiliar with testmon reads that as a skipped suite. This says what it means in AUTHORING.md's development workflow, and points atmake test-allfor data-only changes testmon can't see. The README also calledmake check"the full test and quality suite", which it isn't.Reference
make checkreports "no tests ran" without saying why #771.Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
Abut is not intended to test propertyA's validity, and you made a schema change that invalidates propertyAin that counterexample, fix the counterexample to align it with your schema change.Documentation website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.