Repository navigation
Conversation
Clients can show and preview with the profile the controller runs, including after a reset or a program's select_profile, without a query that would hold the request lock a stop waits on. Older peers decode it as unknown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016uVshJDKTz7nCqrMGVxVJU
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016uVshJDKTz7nCqrMGVxVJU
The interface declares robot as a waldoctl Robot, so a setter narrowed to parol6's Robot is an invalid override to current ty. Same change as #55. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016uVshJDKTz7nCqrMGVxVJU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status stream now carries the active motion profile, as an index into
ProfileType. A client decodes it asmotion_profile, the field added by Jepson2k/waldoctl (branchfix/preview-motion-profile). An absent or unknown index decodes as None, so older peers keep working.Waldo-Commander previews each program with this profile (Jepson2k/Waldo-Commander#87). The stream also follows changes made by a program's
select_profileand byreset_state(), without a query that would hold the request lock a stop waits on.Tests
test_status_tracks_profile_selection_and_reset: a second client watching status sees QUINTIC afterselect_profile(\"QUINTIC\")and TOPPRA afterreset_state(). The snapshot keeps the field.tests/integration/test_profile_commands.py: 19 passed locally.🤖 Generated with Claude Code
https://claude.ai/code/session_016uVshJDKTz7nCqrMGVxVJU