Skip to content

Fix nan-handling in Subplot.from_df checks#496

Merged
dweindl merged 1 commit into
PEtab-dev:mainfrom
dweindl:fix_vis_check
Jun 30, 2026
Merged

Fix nan-handling in Subplot.from_df checks#496
dweindl merged 1 commit into
PEtab-dev:mainfrom
dweindl:fix_vis_check

Conversation

@dweindl

@dweindl dweindl commented Jun 29, 2026

Copy link
Copy Markdown
Member

Fixes UserWarning: For plotId plot13 in column xLabel contradictory settings ([nan nan]). Proceeding with first entry (nan).

@dweindl dweindl requested a review from a team as a code owner June 29, 2026 15:31

@dilpath dilpath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter

codecov-commenter commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.22%. Comparing base (4016147) to head (ce23ea2).

Files with missing lines Patch % Lines
petab/v1/visualize/plotting.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   75.22%   75.22%           
=======================================
  Files          64       64           
  Lines        7145     7145           
  Branches     1261     1261           
=======================================
  Hits         5375     5375           
  Misses       1285     1285           
  Partials      485      485           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Fixes `UserWarning: For plotId plot13 in column xLabel contradictory settings ([nan nan]). Proceeding with first entry (nan).`
@dweindl dweindl merged commit 6935b8b into PEtab-dev:main Jun 30, 2026
7 checks passed
@dweindl dweindl deleted the fix_vis_check branch June 30, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants