Allow for condition ids to be defined inside array files (SciML problems only)#498
Open
BSnelling wants to merge 3 commits into
Open
Allow for condition ids to be defined inside array files (SciML problems only)#498BSnelling wants to merge 3 commits into
BSnelling wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
- Coverage 75.22% 75.11% -0.12%
==========================================
Files 64 64
Lines 7145 7156 +11
Branches 1261 1266 +5
==========================================
Hits 5375 5375
- Misses 1285 1290 +5
- Partials 485 491 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Condition specific inputs to neural networks can be provided as array files for SciML problems. For these condition specific inputs, condition ids referenced in the experiments table need to be defined in the array files rather than the conditions table. https://petab-sciml.readthedocs.io/latest/format.html#inputs
This PR adds:
CheckExperimentConditionsExistvalidation task_convert_experiment(AMICI's sciml support handles condition specific array inputs elsewhere)