Skip to content

Have the SciML linter allow non-yaml network formats#499

Open
BSnelling wants to merge 1 commit into
mainfrom
bes/equinox_format
Open

Have the SciML linter allow non-yaml network formats#499
BSnelling wants to merge 1 commit into
mainfrom
bes/equinox_format

Conversation

@BSnelling

Copy link
Copy Markdown
Collaborator

Such as "equinox": https://github.com/PEtab-dev/libpetab-python/pull/new/bes/equinox_format

For now I didn't include any validation of the network model file, just skip the NNModel construction and validation if the network format is not yaml.

@BSnelling BSnelling requested a review from a team as a code owner June 30, 2026 15:13
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.19%. Comparing base (9a5eb5b) to head (03db394).

Files with missing lines Patch % Lines
petab/v2/extensions/sciml.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   75.22%   75.19%   -0.04%     
==========================================
  Files          64       64              
  Lines        7145     7148       +3     
  Branches     1261     1263       +2     
==========================================
  Hits         5375     5375              
- Misses       1285     1288       +3     
  Partials      485      485              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants