Skip to content

Fix the Build Issue due to Property Names #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drtechie merged 1 commit into from
Jun 22, 2026
+7 −7
Merged

Fix the Build Issue due to Property Names #430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/main/environment/common_example.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,10 @@ otp.ratelimit.day-limit=20
### generate Beneficiary IDs URL
generateBeneficiaryIDs-api-url=/generateBeneficiaryController/generateBeneficiaryIDs

JITSI_APP_ID=piramal_vc
JITSI_APP_SECRET=5b9883418be6f228ffe3ceaa74dd3d3b91737733a4a85c5e82fc584ad449850b
JITSI_DOMAIN=vc.piramalswasthya.org
JITSI_SUB=meet.jitsi
JITSI_TOKEN_TTL_SECONDS=3600
JITSI_ROOM_PREFIX=piramal-meeting-
JITSI_DEFAULT_USER_EMAIL=admin@piramalswasthya.org
jitsi.app.id=<Enter Jitsi App ID>
jitsi.app.secret=<Enter Jitsi App Secret>
jitsi.domain=<Enter Jitsi Domain>
jitsi.sub=meet.jitsi
jitsi.token.ttl.seconds=3600
jitsi.room.prefix=piramal-meeting-
jitsi.default.user.email=<Enter Default User Email>
Comment on lines +238 to +244

@coderabbitai coderabbitai Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify that no other .properties files in src/main/environment/ reference legacy JITSI_* keys
rg -n 'JITSI_(APP_ID|APP_SECRET|DOMAIN|SUB|TOKEN_TTL_SECONDS|ROOM_PREFIX|DEFAULT_USER_EMAIL)' src/main/environment/

Repository: PSMRI/Common-API

Length of output: 1282

Ensure users understand this is an example file requiring local configuration.

Per the coding guidelines for src/main/environment/*.properties files, users must copy this example file to common_local.properties and select the environment via the -DENV_VAR=<env> parameter. If this pattern is not documented in a README or setup guide, consider adding a comment at the top of the file or ensuring the documentation is clear.

Additionally, there is an inconsistency: common_docker.properties (lines 199–205) and common_ci.properties (lines 198–204) reference legacy uppercase environment variables (${JITSI_APP_ID}, @env.JITSI_APP_SECRET@, etc.), while this example file uses hardcoded placeholder values (<Enter Jitsi App ID>, etc.). Standardize the key naming and placeholder approach across all environment-specific .properties files to prevent confusion or configuration override issues.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/environment/common_example.properties` around lines 238 - 244, Add a
prominent comment at the top of the common_example.properties file explaining
that it is an example configuration file that must be copied to
common_local.properties and configured for local use. Additionally, standardize
the Jitsi configuration placeholder approach across all environment-specific
properties files (common_example.properties, common_docker.properties, and
common_ci.properties) by ensuring consistent use of either environment variable
syntax (like ${JITSI_APP_ID}) or a uniform placeholder format (like <Enter Jitsi
App ID>) across all three files to prevent configuration override issues and
user confusion.

Source: Coding guidelines

Loading