Repository navigation
chore: start testing releases at 0.0.1 - #35
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ca5cc4bda
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if not published: | ||
| return True |
There was a problem hiding this comment.
When the first Android job succeeds but a web/Linux/Windows job fails, the workflow still exposes the signed AAB at .github/workflows/release.yml:97-101, while the release job that creates the tag is skipped because it needs every build job. If that AAB is manually uploaded to Play—as the release documentation permits—subsequent runs still have published=False, so this early return disables both semantic-version and Android build-number monotonicity and can allow reuse of build code 1, which Play rejects. Restrict this exception to the specific initial 1.0.0+1 to 0.0.1+1 reset rather than every tagless history.
Useful? React with 👍 / 👎.
Summary
Set the initial client version to
0.0.1+1, keeping the unused Android upload code at1. Allow an initial version reset only when no release tags exist; keep the existing version and upload-code guards for published releases.Fix the Android release job to check out the repository before running steps in
app/, and remove the temporary upload key even if checkout fails.Testing
com.papyrus.reader, version name0.0.1, version code1, signature and 16 KB ZIP alignment verified.release=trueandv0.0.1+1for this change.UI evidence
Not applicable.
Compatibility and migration
No Play upload has used build code
1. Future uploaded builds must increase the code. No runtime or reader changes.Notes
The previous
1.0.0+1workflow was cancelled and published no client release. Merge after the coordinated server PR. Release builds need the existingreleaseenvironment signing secrets and public endpoint settings.Related: server version reset, coordinated workspace release.