Integrate repository cleanup and enforce reader reference consistency - #5
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13dfabe933
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit 513d1774670be1a617affa5249fc06a65d98b1ce | |||
| Subproject commit 57d670a4e734a0312debf9b3439e0efcdbfaf54b | |||
There was a problem hiding this comment.
Pin the post-merge client and reader revisions
If reader PR #3 or client PR #29 is squash- or rebase-merged, this workspace pins the feature-head commits rather than commits reachable from the default branches; the plan itself documents existing squash-equivalent merges and promises to retain these branches only while the PRs are open. Retiring either release branch can therefore make a fresh git submodule update --init unable to fetch the recorded gitlink. After merging the component PRs, update both gitlinks—and the client's reader dependency—to the resulting reachable revisions before merging this workspace commit.
Useful? React with 👍 / 👎.
| Before any remote deletion, record the full tip SHA and PR URL, check tags, | ||
| worktrees, protected/required branches, deployments and dependent PRs. Delete only | ||
| the reviewed head, never force-purge history. A preserved tip can restore the head | ||
| with `git push origin <recorded-full-sha>:refs/heads/<branch>`. |
There was a problem hiding this comment.
Preserve branch objects instead of recording only their SHAs
When a retired branch is the last durable ref to its tip, recording the SHA does not preserve the underlying Git object; after the remote head is deleted, tracking refs are pruned, and unreachable objects are garbage-collected, the documented git push origin <recorded-full-sha>:... recovery command cannot resolve that SHA. Create a retained tag, archival ref, or bundle before deletion whenever rollback is required.
Useful? React with 👍 / 👎.
Coordinate the completed cleanup across the independent repositories and pin the published component revisions. Replace the temporary cleanup plan with the implemented changes; retain durable architecture, contracts and runbooks in their owning repositories.
Extend workspace dependency/check commands and VS Code tasks to include the reader. Add a committed-reference gate comparing workspace gitlinks with the committed client manifest and lock; local overrides cannot mask a mismatch. Tooling CI now checks gitlink changes with recursive checkout. Remove historical baseline logs from DEVELOPMENT.md and remove CLEANUP_PLAN.md.
Separately, nine obsolete remote branches were retired after checking merge/equivalence, open PR use and Pages configuration. Their exact tips remain in local
refs/archive/cleanup-20261003/*, with an ignored rollback record under.local/cleanup/. Obsolete local reader/client/tooling branches and stale tracking refs were removed. No active cleanup/PR branch, default branch or user data was removed.Validation: 13 workspace regression tests plus ShellCheck and reference consistency; 1,315 client tests (19 skipped), four bootstrap tests, analysis and web build; 144 reader tests, two example tests, worker drift check, analysis, web/browser checks; 341 server tests (two external auth smoke tests excluded), Ruff and Mypy; clean strict Sphinx build and API export freshness; website build and six platform-panel browser journeys. Reader CI also builds Linux, Windows and macOS successfully.
Merge reader #4 before client #30, and server #7 before docs #2. Merge the component PRs before this workspace PR. No new task-plan document is added and no schema/data migration is required.