Fix reader HTML and native PDF dependency compatibility - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fresh reader dependency resolution selects
html 0.15.7, which removes the privatematchesAPI used byflutter_html 3.0.0and prevents the reader tests from compiling. The example also lockspdfrx_engine 0.4.5, whose nullable native cache access fails to compile in CI desktop builds.htmlto the compatible0.15.6release, with a comment explaining theflutter_htmlconstraint.pdfrxversion to2.4.8, which requires the corrected PDF engine, and refresh the example lockfile topdfrx_engine 0.4.7.Validation
matchescompilation error locally by resolvinghtml 0.15.7before applying the constraint.flutter pub get --enforce-lockfilepassed without changing the lockfile.git diff --checkpassed.GitHub CI also builds the example on Linux, Windows, and macOS. The parent submodule update is tracked in PapyrusReader/papyrus#3.