Conversation
--crash-log enables logging of which ranks crashed at which callsites. --crash-log takes optional path to log location
When run in session mode, the log can span multiple jobs. Always include executable in crashsite key.
Returning from the signal handler for a "real" fault retries faulting instruction and refaults, but returning from a synthetic signal, such as from kill(getpid(), SIGSEGV), does NOT refault. Detect synthetic signals and explicitly reraise.
If the signal was triggered by the user (e.g., kill(SIGSEGV)), there is no address to check. Treat such a signal as recovered rather than try to check an address we don't have.
SIGSEGV SIG_IGN is ignored for user-sent signals, handled as SIG_DFL for kernel-sent signals
If a thread other than the forking one held a lock at the time of fork, it would disppear holding the lock, leading to a deadlock the next time Spindle tries to acquire it.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dummy PR to force CI to run