Fix audited messages retaining mutated headers#7860
Open
w3lld1 wants to merge 1 commit into
Open
Conversation
|
Hi @w3lld1, Thank you for your contribution! We’ve routed the PR to the appropriate team for evaluation. If only small adjustments are needed, we’ll take care of them. If larger changes are required, we’ll either handle them ourselves (when we have capacity) or let you know what’s needed so you can choose whether to continue, or wait until we’re able to pick it up. Kind regards, |
Member
|
Hi @w3lld1, We need to dedicate some time to investigate the impact of this PR as it will create a new dictionary for every single message that runs through the pipeline. Can you tell us what prompted you to raise this PR? Are you encountering an issue with the current behavior of the audit feature? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
dotnet build src --configuration Release --no-restoreNServiceBus.Core.Tests,NServiceBus.AcceptanceTests,NServiceBus.Core.Analyzer.Tests.Roslyn5,NServiceBus.TransportTests,NServiceBus.PersistenceTests, andNServiceBus.Learning.AcceptanceTests)Fixes #7739