Add support for nullable reference types - ServicePlatform#7863
Open
mchamberlin77 wants to merge 4 commits into
Open
Add support for nullable reference types - ServicePlatform#7863mchamberlin77 wants to merge 4 commits into
mchamberlin77 wants to merge 4 commits into
Conversation
soujay
reviewed
Jul 15, 2026
| } | ||
|
|
||
| static bool IsRetriedMessage(ITransportReceiveContext context, out string retryUniqueMessageId, out string retryAcknowledgementQueue) | ||
| static bool IsRetriedMessage(ITransportReceiveContext context, out string? retryUniqueMessageId, out string? retryAcknowledgementQueue) |
Contributor
There was a problem hiding this comment.
Quick question. Are you also considering adding nullable annotation attributes or are you leaving these out deliberately in internals? For example adding NotNullWhen may be helpful to properly flow the nullable context
And cool we are making progress on nullable 🎉😎
Author
There was a problem hiding this comment.
We haven't looked at those, but they look very useful for some of the cases I have seen. Thanks for pointing them out!
Author
There was a problem hiding this comment.
Added as this was exactly what is needed to express what happens in the method. Thanks again for the suggestion.
npink42
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6257
This PR adds
#nullable enableto theServicePlatformfolder.