fix: preserve OIDC access policy across restart - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result\n- stop the one-time legacy settings migration once encrypted auth.config exists\n- preserve OIDC access mode and allowlist across authentication-service and Server restarts\n- retain the legacy migration path for installations that have not created auth.config\n- add a deterministic regression test that rejects any legacy setting access after migration\n- bump release/readme/security-gate coordinates to v0.4.40\n\n## QA evidence that exposed the bug\nOn Server v1.6.446, a restricted oidc_user/oidc_group allowlist saved and read back correctly, then became empty immediately after restarting the same container. Startup audit events showed UpgradeSettings writing api.auth.allowed.identities from OIDC's absent legacy mapping.\n\n## Acceptance\nCI must run the full Go/race/validation/security gates. The released binary will then be packaged into a new immutable Server patch and verified on 10.0.0.125:8080 with save -> restart -> readback, Authentik TOTP, Passkey, policy switching, token ownership, and cross-tab tests. No production or HAProxy changes.