Fix frozen v1 ProjectTemplate public field - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause and scope
The v1 user API loads a serialized schema without projectTemplate.isPublic. The dynamic overlay added in 0.183.325 reaches v2-beta but cannot add a missing frozen v1 field.
Change
Copy only isPublic from the core schema into the v1 user schema as read-only when absent. Preserve admin create/update and all other resource schemas. Bump Engine to 0.183.326 and document the 0.183.325 v1 limitation.
Verification
Targeted FileSchemaFactoryTest 7/7 passes, including the actual packaged v1 user.ser. git diff --check passes. QA 8080 v475 narrow read-only check independently reproduced v1 omission and v2 success; v326 runtime verification and isolated write matrix remain pending after release.