Fix parsing Vaal Unique modifiers on items#2357
Merged
Merged
Conversation
Blitz54
approved these changes
Jul 8, 2026
Wires77
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
It seems that PoB supports mutated (aka vaal cultivation orb) modifiers properly, but they don't get parsed from items due to the modifier {} text saying "vaal unique" instead of mutated, as was on the non-advanced item strings. This seems to happen simply because the wording doesn't match up with what is defined in the lineFlags variable. I'm not sure if this is hacky, but this seems to work.
This shouldn't change any functionality since as far as I know, the mutated tag doesn't actually do anything (yet?).
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: