Fix Rathpith magnitude of Ailments per 100 Life not scaling Ailments properly#2364
Merged
Merged
Conversation
vaisest
commented
Jul 11, 2026
| @@ -3265,9 +3268,9 @@ function calcs.perform(env, skipEHP) | |||
| -- if not, use the generic modifiers | |||
| -- Scorch/Sap/Brittle do not have guaranteed sources from hits, and therefore will only end up in this bit of code if it's not supposed to apply the skillModList, which is bad | |||
| if ailment ~= "Scorch" and ailment ~= "Sap" and ailment ~= "Brittle" and not env.player.mainSkill.skillModList:Flag(nil, "Cannot"..ailment) and hitFlag and modDB:Flag(nil, "ChecksHighestDamage") then | |||
Contributor
Author
There was a problem hiding this comment.
I'm not really sure what is going on here. I couldn't track down the original intent because these lines have been edited multiple times. The blocks are the same for both paths
LocalIdentity
changed the title
In PR PathOfBuildingCommunity#1034 I changed the handling of the Rathpith mods so that they used ModFlag.Spell instead of Keyword flag That broke the handling of the ailments line though as it uses dotCfg and we specifically strip out the ModFlag.Spell from it so it doesn't get scaled by spell damage. This also stopped the Ailment mod from working though I made it use it's own full parsed line to be simpler and still use KeywordFlag so that the interaction works and the breakdown does too Also added a case so we don't accidentally break this down the line
LocalIdentity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2362.
Description of the problem being solved:
The rathpith per 100 life shock mod wasn't working because the output had no life, and possibly because the code was incorrectly accessing skillCfg, which was always nil.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/poe2/pob/24c22
Before screenshot:
After screenshot: