restore terminal on restart of Atom

[trusktr]

Currently it doesn't restore the terminal:

(the tab is empty)

It would be sweet for terminals to be restored (at least a new terminal, but showing previous output would only be a bonus).

[PerBothner]

This is quite doable. I tried manually selecting Detach session in the contect (pop-up menu), then closing atom. Then after re-starting atom, opening manually a domterm window, I could do domterm --right attach :1 and a new window opened with old (still running session).

Atom is a bit tricky because it does a lot of save and restore automatically (like when moving windows), so figuring out when windows should be saved and when they should be closed was a bit tricky. But if I do it right, it might turn out to be trivial.

[PerBothner]

I checked in a few small fixes - it should work now.

Note you have to update both domterm and atom-domterm.

While you're re-building domterm, I'd appreciate if you could check if setting LDFLAGS, CFLAGS, and CPPFLAGS is still needed.

I'm not sure if the way I'm doing this is quite right - it feels kludgy. One problem is I'm not sure the best way to distinguish when a pane is closed (we want to close the session) vs when we Quit atom (sessions should be detached but not closed).

[trusktr]

Interesting. I haven't tried it yet, but my thought is that if you were to treat quitting Atom the same as closing a tab and close the session in both cases, that may be the easiest and most consistent way to implement it.

As for restoring the session, maybe in that case you could do something similar to macOS Terminal where it shows your previous output, then starts outputting the new sess output below that. So the previous content is there and useful for viewing/copying/referencing from the new (old) session.

Have you used macOS Terminal? Do you know what I mean?

[trusktr]

If I close Atom I'd also like to think that any child processes were also closed.

In the case macOS is restarted (etc), the live sessions will be lost, so the restore-old-output idea would be useful there for example.