fix(dsh): correct lifecycle event mapping for session finish detection - #83
Open
PerfectPan wants to merge 1 commit into
Open
PerfectPan wants to merge 1 commit into
PerfectPan wants to merge 1 commit into
Conversation
… for stop agent/turn-stopping fires at the end of every turn, not at session end. Mapping it to Stop prematurely marked sessions as finished and caused subsequent heartbeats to be ignored. - agent/turn-stopping -> Heartbeat (turn end, session may continue) - agent/status (idle) -> Stop (primary session-finished signal) - agent/disposed, session/disposed -> Stop (secondary finish signals)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dsh plugin mapped
agent/turn-stoppingto theStopevent. However,agent/turn-stoppingfires at the end of every turn (assistant reply), not when the entire session ends. This caused sessions to be prematurely marked asfinished, and subsequent heartbeats were ignored by the state machine (finished sessions only acceptUserPromptSubmitheartbeats).Fix
agent/turn-stopping→Heartbeat(a turn ending doesn't mean the session is over; the user may send another prompt)agent/statuswithstatus === "idle"→Stop(primary session-finished signal: when the agent enters idle, no driver remains scheduled or active)agent/disposed→Stop(secondary finish signal)session/disposed→Stop(secondary finish signal)Validation
pnpm build,pnpm typecheck,pnpm test(328 tests) all passdsh --profile headless: session correctly goes throughSessionStart → Heartbeat → Stopwithstatus: finishedandfinishedAtsetsession/event