fix: forward transition field in 12 AnimatableFilter subclasses - #227
Merged
Conversation
- karaoke, tremolo, vibrato, rotation, distortion, echo, chorus, compressor, lowpass, highpass, phaser, spatial rebuild a fresh object before applyAnimatedUpdate() and drop transition
1Lucas1apk
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
added
transitionback into the settings object passed toapplyAnimatedUpdate()in karaoke, tremolo, vibrato, rotation, distortion, echo, chorus, compressor, lowpass, highpass, phaser, spatialWhy
these 12 filters rebuild a fresh object before calling
applyAnimatedUpdate()and droppedtransitionin the process, so filter changes always applied instantly regardless of what the client sent. only equalizer, timescale, channelMix forward it correctly todayCheckmarks
Additional information
tsc passes