Skip to content

fix: forward transition field in 12 AnimatableFilter subclasses - #227

Merged
1Lucas1apk merged 1 commit into
PerformanC:devfrom
Akinori107:dev
Aug 26, 2026
Merged

fix: forward transition field in 12 AnimatableFilter subclasses#227
1Lucas1apk merged 1 commit into
PerformanC:devfrom
Akinori107:dev

Conversation

@Akinori107

Copy link
Copy Markdown

Changes

added transition back into the settings object passed to applyAnimatedUpdate() in karaoke, tremolo, vibrato, rotation, distortion, echo, chorus, compressor, lowpass, highpass, phaser, spatial

Why

these 12 filters rebuild a fresh object before calling applyAnimatedUpdate() and dropped transition in the process, so filter changes always applied instantly regardless of what the client sent. only equalizer, timescale, channelMix forward it correctly today

Checkmarks

  • The modified endpoints have been tested.
  • Used the same indentation as the rest of the project.
  • Still compatible with LavaLink clients.

Additional information

tsc passes

- karaoke, tremolo, vibrato, rotation, distortion, echo, chorus, compressor, lowpass,
highpass, phaser, spatial rebuild a fresh object before applyAnimatedUpdate() and drop transition
@1Lucas1apk
1Lucas1apk merged commit 0345c59 into PerformanC:dev Aug 26, 2026
1 check passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants