Skip to content

added configuration for game duration, server name, map voting and Web interface through env vars - #24

Open
ppaulis wants to merge 4 commits into
PhasecoreX:masterfrom
osg-lan:master
Open

added configuration for game duration, server name, map voting and Web interface through env vars#24
ppaulis wants to merge 4 commits into
PhasecoreX:masterfrom
osg-lan:master

Conversation

@ppaulis

@ppaulis ppaulis commented Nov 13, 2024

Copy link
Copy Markdown

@PhasecoreX
This PR adds environment variables for game duration, server name, map voting and to enable the web interface of the Server.

Map Voting suggests maps from the game modes : Deathmatch, Domination, CTF, Bombing Run, Assault and Onslaught. Variations with Instagib have also been added.

Best regards,
Pascal

…b interface through env vars

Signed-off-by: Pascal Paulis <ppaulis@gmail.com>
Signed-off-by: Pascal Paulis <ppaulis@gmail.com>
@ppaulis

ppaulis commented Aug 28, 2026

Copy link
Copy Markdown
Author

Hi @PhasecoreX !

Just wanted to know if you had the time to take a look at this? :-)

@PhasecoreX

Copy link
Copy Markdown
Owner

Sorry about that! I have looked at it now.

Server name, web interface, and admin password I think are good. Voting settings are good too, however I think there should be a way to disable it. Currently if they set ENABLE_MAP_VOTING to 0, it won't set it back to False in the config.

I also don't really like the GAME_DURATION one, simply because it modifies all of the game types, and it doesn't modify any custom game types, like JailBreak. I think that's something that would have to be more granular somehow, but I don't want to have a bunch of extra environment variable to support that when it's easier to just manually modify the config file. Best to just remove it.

Signed-off-by: Pascal Paulis <ppaulis@gmail.com>
@ppaulis

ppaulis commented Aug 29, 2026

Copy link
Copy Markdown
Author

@PhasecoreX Fixed the map voting and removed the game duration env var 👍 I'll keep the game duration in my own branch then :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants