Return partial used corners for calibration - #31
Merged
mcm001 merged 5 commits intoAug 2, 2026
Merged
Conversation
Contributor
Author
|
I'm not a big fan of the extra int array for storing ids, |
thatcomputerguy0101
force-pushed
the
partial-observations-corners-used
branch
from
July 30, 2026 17:23
5da6576 to
52e591c
Compare
thatcomputerguy0101
force-pushed
the
partial-observations-corners-used
branch
from
July 30, 2026 17:38
52e591c to
14729e6
Compare
thatcomputerguy0101
force-pushed
the
partial-observations-corners-used
branch
from
July 30, 2026 18:09
14729e6 to
047ddb6
Compare
mcm001
reviewed
Jul 30, 2026
Draft
mcm001
approved these changes
Aug 2, 2026
Open
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
calibrateCamerawould return used corner info for all corners of a board, including those that were not part of the observation. This corrects the problem by changing the input to a list to be able to map the skipped corner info back to the same subset and order that was provided in the parameters.AbstractListcan be used on the caller's side to perform on the fly conversion if needed.