CI smoketest on a virtualized A55 CPU - #33
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates CI to execute an ARM64 smoketest of mrcal_jni_test under qemu-aarch64 (Cortex-A55), and reduces the runtime of the native test executable to better fit CI constraints.
Changes:
- Reduce the
mrcal_jni_testloop iteration count (5 → 1) to shorten execution time. - Extend the build workflow to run
mrcal_jni_testand to stage/upload ARM64 binaries and shared-library artifacts. - Add a follow-on job that downloads the ARM64 artifacts and runs the test under QEMU with
-cpu cortex-a55.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/mrcal_test.cpp |
Reduces test/benchmark iteration count to speed up CI smoketests. |
.github/workflows/main.yml |
Builds/runs native test, stages ARM64 runtime artifacts, and adds a QEMU A55 execution job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://github.com/PhotonVision/mrcal-java/pull/27/changes we added some flags to make sure our Arm64 builds targeted armv8-a, because the Github Actions runner we build on's native architecture includes instructions illegal to run on Orange Pi 5/Pi devices. Let's add a CI test to make sure that we can run on a simulated cortex A55 CPU.
This adds 27 seconds of runtime -- 21 to run the test under QEMU, and 6 to install packages. Windows is still critical path at 10.5 minutes, though