Add SAM2 automasking ModelPool bundle manifest for factory_sim - #831
Add SAM2 automasking ModelPool bundle manifest for factory_sim#831griswaldbrooks wants to merge 1 commit into
Conversation
…nifest The GetMasks2DAutomask Behavior in moveit_pro/#21135 replaces its per-file-path ports (encoder_model_path, prompt_encoder_model_path, decoder_model_path) with model_bundle_manifest + runtime_id. Add the factory_sim SAM2 automask bundle manifest and update the three shipped objectives to match. needs: moveit_pro/#21135
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[written by AI] Paired moveit_pro PR: PickNikRobotics/moveit_pro#21135 — migrates |
[written by AI]
needs: moveit_pro/#21135 — this PR pairs with moveit_pro#21135, which migrates
GetMasks2DAutomaskoff its per-file-path model ports onto aModelPool-backed bundle manifest. moveit_pro#21135 itself depends on moveit_pro#20740 and must merge first; this PR is opened as a draft in parallel for early review, and should merge only after moveit_pro#21135 lands.Motivation
GetMasks2DAutomask'sencoder_model_path,prompt_encoder_model_path, anddecoder_model_pathports are removed in moveit_pro#21135, replaced bymodel_bundle_manifest+runtime_id. The three shippedfactory_simautomasking objectives, and theml_automasking.mdxhow-to guide (in the moveit_pro repo, already updated in #21135), reference the old ports and would break once that PR merges.Brief description
src/factory_sim/models/sam2_automask_bundle.yaml, the versioned bundle manifest for the three existing SAM2.1 automasking model files (sam2.1_hiera_l_image_encoder.onnx,sam2.1_prompt_encoder.onnx,sam2.1_decoder.onnx), matching themoveit_pro.sam2_automask.v1graph ABI andsam2_automaskmodel ID the newSAM2Automaskingfacade expects. SHA-256 digests were computed directly from the shipped model files.factory_simobjectives that callGetMasks2DAutomask(automask_from_file.xml,automask_from_camera.xml,automask_camera_iterate_masks.xml) to setmodel_bundle_manifest=models/sam2_automask_bundle.yaml+runtime_id=onnxruntimeinstead of the three removed path ports.src/factory_sim/models/.How it was tested
Verified the three edited objective XML files still declare
MetadataFieldsand parse as valid BT XML (unchanged structurally aside from the port swap). Did not re-run thefactory_simautomasking objectives end-to-end against moveit_pro#21135's build — that PR is still in draft review.Release notes
None. Internal follow-up to moveit_pro#21135's port rename; no independent user-facing behavior change in this repo.