Repository navigation
Drop dart fix from the pre-commit hook - #40
Merged
Merged
Conversation
It analyzed the whole project to apply a handful of fixes — ~9 s, most of what was left of a commit after #38 — and rewrote files that were not staged. The lints it fixes show in the IDE and block at pre-push; run `dart fix --apply` yourself when they come up. A commit of staged Dart is now import sorting and formatting, about a second. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Follow-up to #38.
dart fix --applywas most of what was left of a commit: it analyzes the whole project (~9 s, the same for one staged file as for all of them) to apply a handful of automated fixes, and it rewrote files that were not staged.The lints it fixes still show in the IDE and block at pre-push, and
dart fix --applyis one command to run when they come up. A commit of staged Dart is now import sorting and formatting — about a second.How it was verified
sh -non the hook.githooks/andsetup_hooks.shchanged — skipped its checks in 2 s, which is Make the git hooks fast: no analysis on commit, only what a push affects #38 doing what it says🤖 Generated with Claude Code