-
Notifications
You must be signed in to change notification settings - Fork 1
Filter cell meta data in ReadPNA_Seurat #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,10 @@ for (assay_version in c("v3", "v5")) { | |
|
|
||
| expect_no_error(suppressWarnings(seur_obj <- ReadPNA_Seurat(pxl_file, return_pna_assay = FALSE, verbose = FALSE))) | ||
| expect_s4_class(seur_obj[["PNA"]], ifelse(assay_version == "v3", "Assay", "Assay5")) | ||
|
|
||
| # Including detailed meta data | ||
| expect_no_error(suppressWarnings(seur_obj_detailed_meta <- ReadPNA_Seurat(pxl_file, detailed_meta_data = TRUE, verbose = FALSE))) | ||
| expect_true(ncol(seur_obj_detailed_meta[[]]) > ncol(seur_obj[[]])) | ||
| }) | ||
|
|
||
| test_that("ReadPNA_Seurat fails with invalid input", { | ||
|
|
@@ -32,7 +36,7 @@ for (assay_version in c("v3", "v5")) { | |
|
|
||
| test_that("ReadPNA_Seurat fails when X collapses to a vector (1 cell)", { | ||
| # Inject an error by subsetting X to have only one cell | ||
| trace(ReadPNA_Seurat, tracer = quote(X <- X[, 1]), at = 13, print = FALSE) | ||
| trace(ReadPNA_Seurat, tracer = quote(X <- X[, 1, drop = FALSE]), at = 14, print = FALSE) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Test accidentally duplicated, losing vector collapse coverageMedium Severity The first test ("fails when X collapses to a vector") was changed from Additional Locations (1)Reviewed by Cursor Bugbot for commit 58788c3. Configure here. |
||
| on.exit(untrace(ReadPNA_Seurat), add = TRUE) | ||
|
|
||
| expect_error( | ||
|
|
@@ -43,7 +47,7 @@ for (assay_version in c("v3", "v5")) { | |
|
|
||
| test_that("ReadPNA_Seurat fails when X is a 1-column matrix", { | ||
| # Inject an error by subsetting X to have only one cell, keeping it as a matrix | ||
| trace(ReadPNA_Seurat, tracer = quote(X <- X[, 1, drop = FALSE]), at = 13, print = FALSE) | ||
| trace(ReadPNA_Seurat, tracer = quote(X <- X[, 1, drop = FALSE]), at = 14, print = FALSE) | ||
| on.exit(untrace(ReadPNA_Seurat), add = TRUE) | ||
|
|
||
| expect_error( | ||
|
|
||


Uh oh!
There was an error while loading. Please reload this page.