Removed presto from DifferentialProximityAnalysis - #165
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 212417c. Configure here.
…sto uses a sligthly different formula for computing p-values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR removes the option to use presto for computing Wilcoxon Rank Sum Tests in
DifferentialProximityAnalysis. The reason is thatpresto::wilcoxaucdoesn't handle negative values correctly.Now the default is limma, but falls back to base R wilcox.test if limma is not installed.
Fixes: DAT-124
Type of change
How Has This Been Tested?
Updated tests for
RunDAAandDifferentialProximityAnalysis. These no longer expect the presto backend.PR checklist:
Note
Medium Risk
Changes the statistical engine for Wilcoxon tests in differential proximity (and related) workflows, so p-values can differ from prior releases when presto was used; the fix targets correctness for negative scores.
Overview
Bumps the package to v0.21.0 and documents the change in
CHANGELOG.mdand the README beta badge.Wilcoxon rank-sum testing in matrix-based differential proximity analysis (
.wilcox_de_test, used byDifferentialProximityAnalysis.Matrix/ Seurat"seurat"method) no longer callspresto::wilcoxauc, which mishandled negative proximity values. The path is nowlimma::rankSumTestWithCorrelationwhenlimmais installed, otherwisestats::wilcox.testper feature, with the install hint updated from presto to limma.Dependencies:
prestoand its GitHubRemotesentry are removed fromDESCRIPTION.limmaremains a Suggests dependency only.Tests refresh expected
p/p_adjvalues intest-DifferentialProximityAnalysis.Randtest-RunDAA.Rto match the new test backend (comments about CI expecting presto are dropped).Reviewed by Cursor Bugbot for commit d117b25. Bugbot is set up for automated code reviews on this repo. Configure here.