fix(events): keep event metadata when a meeting changes room (PPT-2375) - #382
Merged
Conversation
This was referenced Jul 30, 2026
chillfox
marked this pull request as ready for review
July 30, 2026 06:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scenario 5 of PPT-2375, at source: a room move should be a change, not a re-invitation.
Why it happens
Event metadata is stored per room, so moving an event to another system did not find the existing record and started a fresh one. Everything hanging off the meeting was left behind on the old record and rebuilt empty:
staff/guest/attending— arriving downstream as a second, full invitation email,The metadata belongs to the meeting rather than to the room, so a move now takes it with it. With the attendee rows intact,
previously_visitingis true for everyone already attending and the re-announcement stops on its own — the room change is reported bystaff/event/changed, which is what the visitor mailer emails from.The
|| changing_roomclause and theelsif changing_roombranch that forced the re-announcement (added 2020, long before change notifications existed) go with it.Testing
New spec: after a move the same metadata record is reported against the new room with its attendees intact,
staff/event/changedcarriesprevious_system_id, and a visitor who was already attending is not announced again../test— 241 examples, same 5 failures asmaster(4bookings_specsignal payloads + 1 all-day recurring clash e2e, all pre-existing). Format and ameba clean.Stacked on #380. Pairs with PlaceOS/drivers#620, which fixes the duplicate email in the driver and does not depend on this.