build: restore ducklake extension URLs after repo rename-back - #1167
Merged
Conversation
The fork repo is being renamed hoglake -> ducklake (its original name). #1137 pointed the extension downloads at PostHog/hoglake when the repo was renamed away; this restores PostHog/ducklake before a NEW repo claims the hoglake name — repo creation severs GitHub's rename redirect, at which point these URLs would resolve to the new unrelated repo (404 on release assets) instead of the fork. Safe in every interim state: the ducklake->hoglake redirect from the original rename is still live (both linux-amd64 and linux-arm64 v1.0-posthog.7 assets verified fetchable through it today), and after the rename-back the URL is a direct hit.
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The fork repo is being renamed
hoglake→ducklake(its original name), and a new, unrelated repo will take thehoglakename. Creating that repo severs GitHub's rename redirect — at that moment the #1137 URLs (PostHog/hoglake/releases/...) stop redirecting to the fork and resolve against the new repo, 404ing every image build.Changes
Reverts #1137's surviving references: the two extension-download URLs in
Dockerfile/Dockerfile.workerback toPostHog/ducklake. (#1137 also touched three workflow files; later commits already removed those references.)Safe in every interim state, verified today:
ducklake→hoglakeredirect from the original rename is still live — bothlinux-amd64andlinux-arm64v1.0-posthog.7assets fetch 200 through itHow did you test this code?
Curl-verified both arch assets resolve via the restored URLs. No other
hoglakereferences remain in the tree (case-insensitive sweep).