perf: add a cached Trino benchmark variant - #1168
Merged
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frozen perf suite currently measures Trino with filesystem caching disabled. Add a separately labeled
trino_cachedtarget using the same registered DuckLake tables, SQL, warm-up/measurement counts, and 3-CPU/12Gi worker budget.Scheduled runs and manual
posthog_frozen_perfruns execute baseline and cached variants serially in separate disposable namespaces. The cached variant enables Alluxio filesystem caching with a 16GB cache per node and preserves entries between iterations. A default-off provisioner flag controls newly created catalogs. Existing image overrides are rejected for these comparisons so older control planes cannot silently ignore that flag. The original baseline targets remain unchanged.This is filesystem caching, including cached data/footer/index bytes; the pinned DuckLake connector does not use the separate heap metadata-cache tier, and no query-result cache is enabled. Cache budgets, eviction, cleanup, and standalone cached-run instructions are documented.
Validation:
just test-perf,just test-scenario,just test-controlplane-k8s, and thetests/mw-devharness tests pass.bash -nandgit diff --checkpass; review finding about image overrides addressed.just lintreports six existing SA4023 diagnostics, reproduced unchanged on cleanorigin/mainwith the same toolchain.The smoke test validates single-node local-file caching. The full distributed S3 perf comparison has not yet been run.