Skip to content

chore: update Trino benchmark image - #1170

Merged
bill-ph merged 1 commit into
mainfrom
gwyang/update-trino-benchmark-image
Sep 11, 2026
Merged

chore: update Trino benchmark image#1170
bill-ph merged 1 commit into
mainfrom
gwyang/update-trino-benchmark-image

Conversation

@bill-ph

@bill-ph bill-ph commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

The scheduled benchmark still pins a Trino image from before PostHog/trino#31, so runs on Duckgres main do not exercise the redundant Parquet index-read optimization.

Update the shared TRINO_IMAGE pin to the PR #31 merge commit, 59184e0c58c2fdbde031f3a08787c926dc4d7f69, with its verified immutable GHCR digest. Both standard and cached Trino scenarios use this image.

Validation:

  • Verified the GHCR tag resolves to the pinned digest and includes a Linux ARM64 manifest.
  • just test-scenario passed.
  • git diff --check passed; focused review found no issues.
  • just lint reports six Staticcheck SA4023 diagnostics in unchanged Go files (main.go, cmd/duckgres-controlplane/main.go, and controlplane/control.go).

This updates the benchmark input; it does not establish a performance gain. The benchmark has not been rerun with this pin yet.

@github-actions

Copy link
Copy Markdown

Test Impact Plan

Deterministic summary of how this PR changes tests, CI runners, and coverage-risk signals.

Summary

Area Added Changed Deleted
Test files 0 0 0
E2E/journey files 0 0 0
Workflow files 0 1 0

Signals

  • Test cases: +0 / -0
  • Assertions: +0 / -0
  • Skips or known failures added: 0
  • Workflow continue-on-error added: 0
  • Workflow path filters added: 0
  • Test commands removed from justfile: 0
  • E2E/journey retry lines added: 0

Coverage risk: neutral or increased

No coverage-reduction warnings detected.

@bill-ph
bill-ph merged commit 540c54b into main Sep 11, 2026
24 checks passed
@bill-ph
bill-ph deleted the gwyang/update-trino-benchmark-image branch September 11, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant