chore: update Trino benchmark image - #1170
Merged
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled benchmark still pins a Trino image from before PostHog/trino#31, so runs on Duckgres main do not exercise the redundant Parquet index-read optimization.
Update the shared
TRINO_IMAGEpin to the PR #31 merge commit,59184e0c58c2fdbde031f3a08787c926dc4d7f69, with its verified immutable GHCR digest. Both standard and cached Trino scenarios use this image.Validation:
just test-scenariopassed.git diff --checkpassed; focused review found no issues.just lintreports six Staticcheck SA4023 diagnostics in unchanged Go files (main.go,cmd/duckgres-controlplane/main.go, andcontrolplane/control.go).This updates the benchmark input; it does not establish a performance gain. The benchmark has not been rerun with this pin yet.