feat: support explicit registry-only Trino deployments - #1171
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: likely reduced Warnings
|
bill-ph
approved these changes
Sep 11, 2026
bill-ph
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the registry-only Trino deployment path, including strict configuration validation, explicit initial-cell admission before enablement, fail-closed handling for unassigned/unknown ownership, and the accompanying admin/E2E regression coverage. I found no P0 blocker requiring a code change. The PR is appropriately kept as draft pending the extended live Trino CI lane; current CI is still in progress.\n\n— Robo Bill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DUCKGRES_TRINO_REGISTRY_ONLY=truesupport for deployments with registered cells and no legacy coordinator. The default still rejects a missing legacy URL; registry-only mode requires a valid registry and rejects mixed configuration.Validation
just test-trino,just test-controlplane-k8s,just test-mw-fixtures,just ui-test(195 tests), andjust lintpass locally.Draft until the extended live Trino CI lane passes. This does not alter a shared deployment.