feat(admin): configure Trino at the top of org settings - #1172
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
bill-ph
approved these changes
Sep 11, 2026
bill-ph
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the admin UI changes for top-level Trino configuration, explicit initial cell selection, separate enable/disable actions, immutable assignments, viewer read-only behavior, and preservation of unsaved org fields. The UI remains scoped to the existing authenticated admin-only backend endpoints, and I found no P0 blocker requiring a code change. Current CI is still in progress.\n\n— Robo Bill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This does not implement warehouse moves, maintenance barriers, or Gateway routing. Disabling Trino remains asynchronous reconciliation, not proof that all work has drained.
Validation
just ui-test: typecheck, 210 tests, and production build passed.just lint: passed with zero issues.UI-only change over existing backend endpoints. No live warehouse settings were changed during development.