Chore: cleanup output.hpp - #1529
Draft
mgovers wants to merge 1 commit into
Draft
Conversation
mgovers
added
improvement
mgovers
force-pushed
the
pgm/feature/supernode-output
branch
from
August 12, 2026 07:29
dc1514e to
412bf7c
Compare
2 tasks
mgovers
force-pushed
the
pgm/feature/cleanup-output
branch
from
August 12, 2026 07:56
e211e91 to
befcbd0
Compare
mgovers
force-pushed
the
pgm/feature/supernode-output
branch
from
August 12, 2026 08:07
464bbe6 to
c0f0141
Compare
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> remove unused Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> clang-format Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
force-pushed
the
pgm/feature/cleanup-output
branch
from
August 12, 2026 08:12
befcbd0 to
42f7829
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup after #1520 .
The conversion from math output to output data can benefit from a serious cleanup, especially because it's become a bit tricky to extend. During work on #1520 (contributing to #35 ), some initial work was added. However, since it did not directly contribute to the output, it was cherry-picked out of that PR. Since it's still beneficial to the overall PGM core, here it is.
NOTE: this is not a final state but a step in the right direction. It has become clear that there's some duplication that can be cleaned up during follow-up work