Support structured state publication and preserve empty-domain controls - #12
Merged
Conversation
PraneethMerugu
changed the base branch from
codex/ecosystem-candidate-ci
to
main
September 9, 2026 00:39
PraneethMerugu
marked this pull request as ready for review
September 9, 2026 00:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support immutable named products in field storage and publication
Required companion to G04 structured state in CorePotts, following merged
LocalMath CI PR11.
Targets main c595f91, whose tree is identical to tested parent135afe4;
final tested head is e51eeaf. The sections below distinguish
earlier validation from the complete final-head results.
Changes
predicate and reuse that predicate for evaluator type parameters.
preserving size, alignment, field-layout and backend leaf-operation checks.
atomic algebra, reduction algebra or backend-specific scientific meaning.
ownership, unsupported nested leaves, oversize records and unsafe captures.
the contributor architecture documentation.
Validation
The following broad validation was completed at
87de468, before theworld-age correction described below:
the additional reviewer-requested tests, package quality and inventory checks.
with scalar GPU indexing disabled.
compacted examples and eight authored-domain checks).
87de468: no blocking findings. Reviewer-requestedrouted/layout witnesses are integrated in both ordinary inventories.
Logs are in the coordinator workspace's
.worktrees/validation-logs/, using thelocalmath-product-prefix. These are local runs, not hosted Actions results.Recursive admission correction
Downstream authored RNG integration exposed a generated-function world-age
failure for a concrete record nested inside a tuple. Follow-up
121a385emitsrecursive checks into generated method bodies, leaving the same storage
predicate and conservative admission semantics in place. It adds a public
tuple-wrapped callable publication witness and nested rejection checks.
32274682, CorePotts334cbe6, and LocalMath121a385. It exercises aBernoulli guard, Uniform drive, accepted-copy draw publication, qualified-key
rename behavior, and checkpoint continuation.
this follow-up revision.
Scope
Closed ordered-fold gates
Follow-up
df9a650fixes the existing ordered-fold path to honor a closed gatebefore evaluating events and before publishing private initializer state.
The ordinary regression reproduced six failures before the correction, then
passed 26 gate checks plus 43 existing fold checks on CPU; the same 26 gate
checks passed on actual Metal. Root independently reviewed the correction.
Active duplicate identities still fail. The downstream public compound suite
passed 47/47, including the original mixed relationship rollback case, using
Potts
e5763ed5, Cored1db5e3, and LocalMathdf9a650.Strict documentation passed at
df9a650in an isolated copy of the declareddocumentation environment. The complete ordinary package suite passed
1,552/1,552 at that revision, including quality and inventory checks. The
complete LocalMath Metal runner passed 273/273, including its host-side product
fixtures and actual-device scientific witnesses, with scalar indexing disabled.
The separate CPU scientific examples passed 29/29. CorePotts's complete Metal
inventory separately passed 168/168 with Core
d1db5e3and LocalMathdf9a650.Empty pointwise source domains
Follow-up e51eeaf fixes an out-of-bounds destination read when a direct
pointwise source has zero items. Padded lanes now check the source bound before
accessing values or evaluating work. The existing control checks still run for
the empty domain, including invalid-prefix diagnostics. Single and fused laws
share the same control handling; no alternate executor or zero-degree relation
exception was added.
Final-head validation at e51eeaf:
quality and inventory (run14205).
empty-domain controls with scalar indexing disabled.
Hosted run34294897711 also passed complete package, strict docs, scientific,
macOS smoke and actual Metal jobs. Main/manual-only full macOS was skipped.
After PR11 merged with ancestry preserved, this PR was retargeted to main;
the merged parent tree is identical to the tested parent, with no source change.
Independent reviews and final-head validation are complete for this scope.
Validated products contain Boolean, integer and Float32 tuple/static-vector
leaves within the existing bounded record layout. Admission depends on the
actual backend and operation. This does not promise arbitrary records, new
atomic/reduction support, exact cross-device replay, or measured speedups.
Metal retains its own explicit unsupported-Float64 allocation diagnostic.
The concrete downstream consumer is CorePotts's typed structured-state stage
publication. Its separate transaction and lifecycle validation must complete
before claiming the entire G04 authoring workflow is supported.