Copy allocated arrays through backend-owned transfers - #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generic destination copy on device storage
transfer boundary while retaining native device-to-device transfers
host views on Metal, and native
MtlArraysourcesWhy this is required
CorePotts' structured maintained-quantity rebuild supplies ordinary array views
to LocalMath's existing
Allocate(source)boundary. The former genericcopyto!implementation attempted scalar indexing when that host view targetedMetal storage. This change corrects the sole cold allocation copier; it adds no
second executor, storage authority, or backend registry.
Validation
git diff --check: passedCPU and Metal are the qualified paths. Dispatch applicability is not presented
as a blanket capability guarantee for CUDA, ROCm, custom backends, or arbitrary
provider array wrappers; those combinations retain their own later conformance
work.