Enhance TimestampSplit to support ratio-based data splitting#712
Merged
hieuddo merged 2 commits intoJul 18, 2026
Merged
Conversation
Member
|
Thank you for the PR! I pushed a few guards for edge cases:
|
hieuddo
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #693.
TimestampSplitnow accepts ratios (test_size,val_size) and computes the timestamp cutoffs automatically, so users no longer have to find the exact cutoff values by hand. The absolute-cutoff API is unchanged — the timestamp args just became optional, and the mode is picked by which args are given.Ratios are counted by number of interactions (like
RatioSplit). Interactions sharing a boundary timestamp stay on one side to avoid leakage, so the realized ratio is approximate under tied timestamps.Related Issues
Follow-up to #693 (original
TimestampSplit), addressing #689.Checklist:
README.md(if you are adding a new model).examples/README.md(if you are adding a new example).datasets/README.md(if you are adding a new dataset).