Skip to content

Fix redundant array check in purchase event #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Codencode wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix redundant array check in purchase event #185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1013bb6
Fix redundant array check in purchase event
Codencode Sep 6, 2026
2fbadcb
Add native types to GoogleAnalyticsTools methods
Codencode Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions classes/GoogleAnalyticsTools.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,13 @@ class GoogleAnalyticsTools
* @param array $orderData
* @param string $callbackUrl
*
* @return string|void
* @return string
*/
public function renderPurchaseEvent($orderProducts, $orderData, $callbackUrl)
{
if (!is_array($orderProducts)) {
return;
}

public function renderPurchaseEvent(
array $orderProducts,
array $orderData,
string $callbackUrl
): string {
$callbackData = [
'orderid' => $orderData['transaction_id'],
'customer' => $orderData['customer'],
Expand Down Expand Up @@ -72,8 +71,10 @@ public function renderPurchaseEvent($orderProducts, $orderData, $callbackUrl)
*
* @return string json encoded data
*/
public function jsonEncodeWithBlacklist($data, $ignoredKeys = [])
{
public function jsonEncodeWithBlacklist(
array $data,
array $ignoredKeys = []
): string {
$return = [];

foreach ($data as $k => $v) {
Expand All @@ -97,8 +98,11 @@ public function jsonEncodeWithBlacklist($data, $ignoredKeys = [])
*
* @return string render gtag event for output
*/
public function renderEvent($eventName, $eventData, $ignoredKeys = [])
{
public function renderEvent(
string $eventName,
array $eventData,
array $ignoredKeys = []
): string {
// Automatically add send_to parameter to all events to avoid sending extra events
// to other gtag configs (Ads for example).
$eventData = array_merge(
Expand Down
Loading