Repository navigation
fix(invoices): auth for print/PDF in new tabs - #69
Merged
Merged
Conversation
window.open cannot carry an Authorization header, so the invoice print/PDF endpoints returned 401. Now: - server: attachTokenFromQuery middleware lifts a ?token= query param into the Bearer header (stripped before the request is processed/logged); mounted on the /invoices router before auth. - frontend: AdminInvoices appends getAuthToken() to the print/pdf URLs; getAuthToken exported from services/api. Verified: print -> 200, pdf -> 200 application/pdf with ?token=; access logs are written to server/logs/info-*.log. Lint clean; no test impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New-tab print/PDF links couldn't send the Bearer header -> 401. Accept a
?token=query param (stripped before logging) and append it client-side. Verified 200/application/pdf. Lint clean.