Repository navigation
feat(invoices): print-tab toolbar + PDF download polish - #70
Merged
Merged
Conversation
- Print page now renders an on-screen toolbar (Print / Download PDF / Close) that is hidden by @media print; the Download link reuses the tab's token to fetch the PDF (attachTokenFromQuery now stashes req.tokenFromQuery). - PDF download already returns Content-Disposition: attachment with a friendly filenname (INV_FY_SEQ_fmt.pdf) — verified end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print opens a clean new tab with an action bar (Print / Download PDF / Close, hidden when printing); PDF downloads as an attachment with a friendly filename. Verified 200 + Content-Disposition attachment.