Feat/handheld UI - #3
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
Important Review skippedToo many files! This PR contains 192 files, which is 92 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (192)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 192 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 19 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/rocknix_build_regression_test.sh">
<violation number="1" location="tests/rocknix_build_regression_test.sh:147">
P3: The fake `make` appends to `$MAKE_MARKER` with `>>`, so the count accumulates across build invocations within the same test process. The success-path assertion `wc -l = 2` only passes because the failure run never reaches `make` and leaves the marker uncreated. If the failure path ever invokes `make` (or the test is reordered), this count silently becomes wrong and the assertion reports a misleading failure. Reset the marker before the success run to keep the two build steps independent.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| "$ROOT/tools/build-rocknix-h700-cedrus.sh" "$kernel_tree" "$success_output" \ | ||
| >"$TEST_ROOT/success.log" 2>&1 || fail "ROCKNIX module build rejected a valid build" | ||
|
|
||
| [ "$(wc -l <"$make_marker" | tr -d ' ')" = 2 ] || fail "ROCKNIX module build did not run both make steps" |
There was a problem hiding this comment.
P3: The fake make appends to $MAKE_MARKER with >>, so the count accumulates across build invocations within the same test process. The success-path assertion wc -l = 2 only passes because the failure run never reaches make and leaves the marker uncreated. If the failure path ever invokes make (or the test is reordered), this count silently becomes wrong and the assertion reports a misleading failure. Reset the marker before the success run to keep the two build steps independent.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At tests/rocknix_build_regression_test.sh, line 147:
<comment>The fake `make` appends to `$MAKE_MARKER` with `>>`, so the count accumulates across build invocations within the same test process. The success-path assertion `wc -l = 2` only passes because the failure run never reaches `make` and leaves the marker uncreated. If the failure path ever invokes `make` (or the test is reordered), this count silently becomes wrong and the assertion reports a misleading failure. Reset the marker before the success run to keep the two build steps independent.</comment>
<file context>
@@ -78,4 +118,40 @@ grep -q "failed to apply patch" "$build_output" || fail "ROCKNIX patch failure w
+ "$ROOT/tools/build-rocknix-h700-cedrus.sh" "$kernel_tree" "$success_output" \
+ >"$TEST_ROOT/success.log" 2>&1 || fail "ROCKNIX module build rejected a valid build"
+
+[ "$(wc -l <"$make_marker" | tr -d ' ')" = 2 ] || fail "ROCKNIX module build did not run both make steps"
+[ -e "$dtc_marker" ] || fail "ROCKNIX module build did not compile the device-tree overlay"
+[ -e "$xxd_marker" ] || fail "ROCKNIX module build did not embed the device-tree overlay"
</file context>
1 participant
What does this change?
build.zig.How did you test it?
tools/zig.sh buildtools/zig.sh build testtools/zig.sh build fmt-checkPORTMASTER_NEW=/path/to/PortMaster-New tools/zig.sh build packageSummary by cubic
Migrates the runtime from C to Zig and adds a controller-first handheld UI alongside ROCKNIX H700 support via a new V4L2 Request decoder. Streams now match the device display resolution instead of requesting fixed 720p.
New Features
Build and dependencies
build.zigbuild using pinned dependency commits and hash checks; ROCKNIX module builds now stop when patches fail and are covered by a regression test.Written for commit abb3a6c. Summary will update on new commits.