Skip to content

Add AmberELEC deployment support - #21

Merged
Producdevity merged 1 commit into
masterfrom
feat/amberelec-deploy
Aug 26, 2026
Merged

Add AmberELEC deployment support#21
Producdevity merged 1 commit into
masterfrom
feat/amberelec-deploy

Conversation

@Producdevity

@Producdevity Producdevity commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Adds an AmberELEC deploy wrapper and the matching /storage/roms defaults.

The README now lists the AmberELEC command alongside the other CFW-specific deploy scripts.


Summary by cubic

Adds AmberELEC as a supported deployment platform so you can deploy with scripts/deploy-amberelec.sh <ssh-host>.

  • Adds a wrapper script that calls the shared scripts/deploy.sh amberelec.
  • Registers the amberelec platform with default root /storage/roms, matching ROCKNIX.
  • Supports --root PATH, --storage, and the CODBOZ_AMBERELEC_DEPLOY_HOST / CODBOZ_AMBERELEC_DEPLOY_ROOT env vars.
  • Documents the new command in the README next to the other CFW deploy scripts.

Written for commit 8e84d56. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features

    • Added deployment support for AmberELEC devices.
    • Added an AmberELEC deployment command with argument forwarding.
    • Configured the default AmberELEC storage location and deployment host option.
  • Documentation

    • Updated deployment documentation with AmberELEC setup instructions, command usage, and default options.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6cb72f3e-f04c-4611-be5c-1c30c703d81d

📥 Commits

Reviewing files that changed from the base of the PR and between 4491451 and 8e84d56.

📒 Files selected for processing (3)
  • README.md
  • scripts/deploy-amberelec.sh
  • scripts/deploy.sh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

AmberELEC support adds a deployment wrapper, platform configuration, usage details, and README documentation. The configuration uses /storage/roms by default and supports host and root overrides.

Changes

AmberELEC deployment

Layer / File(s) Summary
AmberELEC deployment path
scripts/deploy-amberelec.sh, scripts/deploy.sh
The new wrapper forwards arguments to the amberelec target. The shared script configures /storage/roms, the ports directory, host and root overrides, and AmberELEC usage text.
Deployment documentation
README.md
The README documents the AmberELEC deployment command, its default storage path, and the --root PATH option.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 8e84d

This localized change adds AmberELEC deployment support and matching defaults; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding AmberELEC deployment support.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/amberelec-deploy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Producdevity
Producdevity merged commit 49b9916 into master Aug 26, 2026
2 of 3 checks passed
@Producdevity
Producdevity deleted the feat/amberelec-deploy branch August 26, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant