Skip to content

Fix missing music and audio cues - #22

Merged
Producdevity merged 1 commit into
masterfrom
fix/missing-music-cues
Aug 26, 2026
Merged

Fix missing music and audio cues#22
Producdevity merged 1 commit into
masterfrom
fix/missing-music-cues

Conversation

@Producdevity

@Producdevity Producdevity commented Aug 26, 2026

Copy link
Copy Markdown
Owner

The port was treating Marmalade's logical audio channels as one global music stream. Starting another track replaced the previous channel and caused several music and audio cues to disappear.

This restores the two independent logical channels used by the game and keeps their playback state separate.

Addresses #20


Summary by cubic

Fixes missing music and audio cues by restoring the two independent logical audio channels that Marmalade expects. Previously, the port treated audio as a single stream, so playing a new track replaced the previous one and caused cues to disappear. Addresses #20.

  • Restores independent playback state for each logical audio channel.
  • Switches stream playback from the music API to the mixer's channel API.
  • Updates tests to cover two simultaneous audio streams and per-channel stop/callback behavior.

Written for commit 2b4d032. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 55 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fef4af6c-ad12-453e-bbc0-94ae027cd0b3

📥 Commits

Reviewing files that changed from the base of the PR and between a337bf0 and 2b4d032.

📒 Files selected for processing (2)
  • src/s3e_audio.c
  • tests/s3e_audio_test.c

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Producdevity Producdevity reopened this Aug 26, 2026
@Producdevity
Producdevity merged commit bb77f45 into master Aug 26, 2026
3 of 4 checks passed
@Producdevity
Producdevity deleted the fix/missing-music-cues branch August 26, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant