Repository navigation
Integrate desktop training fixes on the API completion branch - #265
Draft
ProfSynapse wants to merge 7 commits into
Draft
ProfSynapse wants to merge 7 commits into
ProfSynapse wants to merge 7 commits into
Conversation
…api-v1-completion
…api-v1-completion # Conflicts: # .agents/skills/fine-tuning/reference/sft-training.md # .claude/skills/fine-tuning/reference/sft-training.md # .skills/fine-tuning/reference/sft-training.md
…api-v1-completion # Conflicts: # .agents/skills/fine-tuning/SKILL.md # .claude/skills/fine-tuning/SKILL.md # .skills/fine-tuning/SKILL.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect the reviewed desktop-training fixes on a dedicated API completion branch: model SDK validation before consuming preparation claims, closed offline SFT worker diagnostics, and the internal MLX prepared-token SFT boundary. This gives qualification a single pushed source while keeping main unchanged.
Validation on exact head 0d515ae: all 18 CI checks passed, including Linux/Windows/macOS installed-base compatibility and provider-free coordinator conformance. The integrated local suite passed 265 CPU tests; all seven closure/lock checks are current and canonical skill mirrors match. Independent reviews accepted the diagnostics and internal MLX scope.
Live qualification remains incomplete. The fresh Windows SFT attempt failed at the closed Torch-import boundary; the fresh Modal GRPO attempt passed its CPU package check but failed at trainer construction. Neither failure establishes its underlying cause. Both consumed attempts are preserved. Apple execution still needs the native runtime/provider joins and real hardware qualification. Syntunia's private planning and known-run read bridge is merged, while product training custody and the engine pointer remain separate gates. This draft is not a qualified release.
Includes the changes reviewed in #263 and #264 plus the independently reviewed MLX increment f072d97. Further reviewed fixes target this branch. HF Jobs qualification remains paused.