Verify Dark Sun: Wake of the Ravager - #755
Open
tomojira wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying Dark Sun - Wake of the Ravager (1994) (SSI)
Checklist
The original PR added the floppy version of this game because the Masterpiece Collection CD had static as audio Track 2 and 3, a real error with how it was produced at the time.
However I was able to get a different CD version working, matching with TDC#23 entry: Dark Sun- Wake of the Ravager CD v1.0 (1994)(Strategic Simulations, Inc.) [bin-cue]
I used this CD version as the main variant, and moved the floppy version to Misc variants (some may prefer it since there's no voice acting, and there's Sound Blaster/General MIDI music).
Note that the installer for the CD version may erroneously say there's not enough disk space, when there's actually too much disk space. This happened to me when trying to install from the CD in a DOSZ like I usually do, but it worked when I tried the normal DOSBox way of mounting a folder with the CD as C, then imgmounting the CD as D.
Have adequate installation instructions been provided to match any config files in the DOSZ?
The config file isn't needed in the DOSZ. It can be created by
SOUND_DS.EXE(CD version) orSOUND.EXE(floppy version).The default character file
CHARSAVE.GFFwill change later, but it's too large for embedded data, so I included a copy in the DOSC.Have any official patches been applied, if necessary?
Yes, I applied the original CD version of patch v1.1 (wakecd11.zip): https://www.patches-scrolls.de/patch/1112/7/41263/download
Note there are different patches for a later jewel case CD version, and for the floppy version.
In any case, the floppy version used is already v1.1.
This version is also what GOG uses, so it might be safer to share files.
Is the game data in the root of the ZIP (unless game does not work that way)?
It was, but I moved it to
C:\RAVAGERfor ease of transferring saves.For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
There is an option for it, but I was unable to get it working - there were always issues with the audio and cutscenes, even using the modified BAT file that gets installed which is supposed to handle it. I stuck with the full installation.
Is the entry in the right variant file (i.e. Freeware)?
Yes.
Have digital versions (Steam, GOG) been checked for matching?
Yes, a GOG variant was already added. It cannot match the main variant because of its CD image.
Can the game benefit from using embedded data or embedded patches in the datfile?
I added embedded data to
RAVAGER.BAT.Can DoDAT build the game from the install media?
No. CD version's patch files and floppy version's main files are in containers.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.
Do the file timestamps match the installation media?
Yes.
Does the DOSZ run standalone?
Yes.
For CD games, can the game be set up to run without a CD mounted?
Unknown. TDC uses a crack to do it, but the audio tracks are needed anyway.
Can the game benefit from using CHDtoOGG?
Yes, I used it with the default settings.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.
Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Does the DOSC have copy protection removed, if possible?
CD version: There is no copy protection according to PCGamingWiki.
Floppy version: The copy protection removal was in the DOSZ, with a backup of the original file. I changed it so only the original file is in the DOSZ, with a patch in the DOSC.
Is the game running at the correct speed? Is CPU year specified?
cpu_year: 1994was set, but I changed to 1990 to slow down the game (a little lower than GOG's 15000 cycles).Is the DOSC auto-running and skipping past any obstructions? Is it updated to use WAITMODECHANGE if possible?
Yes.
Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
No.
Does the game have General MIDI support?
CD version: No.
Floppy version: Yes, I added it
Is the game set up to run with the best quality graphics options by default?
Not applicable.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
Yes, I enabled it.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Yes, I added a Dark Sun series .savename.
Summary of changes
C:\RAVAGERfor ease of transferring savesRAVAGER.BATcpu_year: 1990