Repository navigation
Infer charging from a rising level on Bluetooth devices - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Shows Bluetooth devices as charging when their level keeps rising.
BluetoothBatterySourcealways reported Discharging. It now marks that state as a guess (BatteryReading.StatusIsAssumed); anUnknownstate counts the same.ChargingInferenceruns in the poll loop before the registry, so the widgets, thechargingandstatusvariables, the trend and the charging started/stopped events all see the same state.Checklist
dotnet buildanddotnet testpass locally (0 warnings, 265 tests).Device/hardware tested against (if applicable)
The rules are covered by unit tests with a fake clock.