CI: run the ASan/UBSan job in a container instead of on macOS - #862
Merged
Conversation
The job was hanging in `brew install llvm@19`. Use the prebuilt ghcr.io/nascheme/cpython-asan image, as NumPy now does for its Linux ASan job: it ships clang-21 and an ASan-instrumented CPython 3.14, so no Homebrew, no pyenv and no interpreter build are needed. Set ASAN_OPTIONS=detect_leaks=0 for the build. LeakSanitizer is on by default under ASan on Linux (on macOS it is unsupported), and makes the numpy include-dir probe in pywt/_extensions/meson.build exit non-zero. Skip test_swt2_iswt2_integration, which costs ~3.5 minutes and covers the same C code as test_swt2_iswt2_quick and test_swtn_iswtn_integration, and drop the unused CYTHON_TRACE and CYTHONSPEC env vars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job was hanging in
brew install llvm@19. Use the prebuilt ghcr.io/nascheme/cpython-asan image, as NumPy now does for its Linux ASan job: it ships clang-21 and an ASan-instrumented CPython 3.14, so no Homebrew, no pyenv and no interpreter build are needed.Set
ASAN_OPTIONS=detect_leaks=0for the build. LeakSanitizer is on by default under ASan on Linux (on macOS it is unsupported), and makes the numpy include-dir probe inpywt/_extensions/meson.buildexit non-zero.Skip
test_swt2_iswt2_integration, which costs ~3.5 minutes and covers the same C code astest_swt2_iswt2_quickandtest_swtn_iswtn_integration, and drop the unusedCYTHON_TRACEandCYTHONSPECenv vars.AI usage declaration: used Claude Opus 5.0 for debugging and fixing things up. I didn't know about the (fairly brain dead)
pyenv rehashthing, so this saved me a bunch of head-scratching.