Follow-up to #24/#25: typography and consistency fixes from the validation review - #26
Open
mmcky wants to merge 1 commit into
Open
Follow-up to #24/#25: typography and consistency fixes from the validation review#26mmcky wants to merge 1 commit into
mmcky wants to merge 1 commit into
Conversation
…ation review Applies the mechanical items from the validation of Emile's editor PRs, leaving the editorial rulings (cours/chapitre, plat sweep, package contexts) open in the #24/#25 threads: - restore U+00A0 before the five new sentence-level colons (numpy ×4, python_by_example ×1) per the edition's typography convention - « loi uniforme bidimensionnelle » → « bivariée » in the pbe_ex5 solution, matching the unchanged hint and the glossary pin - « En revanche, dans un programme long, … » → « Il devient alors plus difficile … » — the English "Then it's harder…" is a consequence of the preceding disadvantage, not a contrast, and this drops the « long programme »/« programme long » repetition - unstrand the Packages back-reference: « Comme indiqué ci-dessus, NumPy est un package Python » referred to a sentence #25 reworded to « bibliothèque »; now « NumPy, que nous avons présenté plus haut, est un package Python » Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Follow-up PR applying small, mechanical consistency fixes in the French lecture notes after the validation review, focusing on typography (French punctuation spacing) and a few wording/terminology alignments.
Changes:
- Adjusts spacing before “:” in a handful of sentences to match the project’s French typography convention.
- Refines two sentences for consistency/clarity around imports (
sqrt) and the “package” definition of NumPy. - Aligns Exercise 5 wording to “loi uniforme bivariée”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lectures/python_by_example.md | Wording tweaks (packages/imports) + typography before “:” + “loi uniforme bivariée” in ex. 5 solution |
| lectures/numpy.md | Typography fixes for spacing before “:” in a few introductory sentences |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Ici `append()` est ce qu'on appelle une **méthode**, c'est-à-dire une fonction « attachée à » un objet --- dans ce cas, la liste `x`. | ||
|
|
||
| Nous étudierons les méthodes plus en détail dans un {doc}`chapitre ultérieur <oop_intro>`. Pour le moment, retenons simplement que : | ||
| Nous étudierons les méthodes plus en détail dans un {doc}`chapitre ultérieur <oop_intro>`. Pour le moment, retenons simplement que : |
📖 Netlify Preview Ready!Preview URL: https://pr-26--verdant-toffee-3261a8.netlify.app Commit: 📚 Changed LecturesBuild Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Honaminto — merci encore pour #24 and #25, both now merged. This small follow-up applies the four mechanical items from our validation review so you can verify them with a one-click approve (and the Netlify preview below) instead of hand-editing invisible characters through your fork. Could you review?
What it changes (8 lines across the two lectures):
Bivariate uniform distribution → Loi uniforme bivariée. If you'd argue for « bidimensionnelle » instead, say so and we'll change the glossary pin rather than the sentence.sqrt. » — the English "Then it's harder…" is a consequence of the disadvantage just stated, so « En revanche » (contrast) was the wrong connector; this also removes the « dans un long programme »/« dans un programme long » repetition across consecutive sentences.Still yours to rule on, in the #24/#25 threads — nothing here pre-empts them: « cours » vs « chapitre » (fleet-wide term), finishing the « tableau plat » sweep (4 remaining in numpy.md), where « package » should stay « package » elsewhere, and the two softening confirmations.
🤖 Generated with Claude Code