Repository navigation
Conversation
kshyatt
marked this pull request as draft
October 6, 2026 15:19
kshyatt
marked this pull request as ready for review
October 7, 2026 09:56
kshyatt
force-pushed
the
ksh/batched_eigh
branch
from
October 7, 2026 09:56
015759c to
a3367bf
Compare
kshyatt
force-pushed
the
ksh/batched_eigh
branch
from
October 21, 2026 09:58
83161ab to
386fc8d
Compare
- copy eigenvalues into diagview(Ds[i]) from the (n, b) packed output - don't zero-pad ragged batched_eigh_vals!, padded zeros interleave with the spectrum - restrict CUDA ragged eigh support to Jacobi - remove duplicate supports_pointer_batch definition in AMD extension Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lkdvos
force-pushed
the
ksh/batched_eigh
branch
from
October 29, 2026 13:58
386fc8d to
26187a9
Compare
… SVD - add a default_eigh_algorithm for vectors of matrices, use AbstractVector in the CUDA ext - fix the batched_eigh_full docstring - limit CUSOLVER's batched block size to Jacobi - move the batched eigh gaugefix! next to the batched SVD ones - drop the unused BATCHED_EIGH_THRESHOLD, fix typos, match SVD algorithm order - test ragged batch support per algorithm, drop unused test_trunc options Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- pass an array of pointers for Z to syevx_batched instead of the dense V - copy the eigenvectors back from each A[i] into its slice of V - accept a 3D V in heevj_batched! - free the device pointer arrays after each call Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Thanks for picking this back up! |
Member
|
still have some more fixes incoming btw, let's hope this now works |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs AMD support