Repository navigation
Conversation
lkdvos
reviewed
Oct 29, 2026
Merged
lkdvos
reviewed
Oct 29, 2026
lkdvos
reviewed
Oct 29, 2026
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
approved these changes
Oct 29, 2026
Member
Author
|
There seem to be very few changes needed in TensorKit except extra tests. I'll make a PR there soon. |
Member
|
Note that you first need another patch release here for that to be picked up |
lkdvos
enabled auto-merge (squash)
October 29, 2026 23:38
Member
|
ROCm test queue is super backed up again, I might just force-merge this |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows an empty Q output in
left_orth!andright_orth!to skip constructing the orthogonal basis, enabling R/L-only computation, using preallocated R/L outputs:There are some renaming of internal helper functions for consistency:
_diagonal_qr!_qr_diagonal!_diagonal_qr_null!_qr_null_diagonal!lq_diagonal!_lq_diagonal!lq_null_diagonal!_lq_null_diagonal!Closes #109. I expect this to eventually offer much boost in PEPSKit simple update for gates beyond nearest neighbor ones.