Repository navigation
Conversation
lkdvos
reviewed
Oct 29, 2026
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
Would it make sense to immediately move this to a GPUArrays extension that unifies the kernels as well? Otherwise definitely looks good!
Member
Author
|
I've been wanting a GPUArrays extension for a while anyway, let me do that here |
Member
Author
|
I forgot to change the kernel syntax anyway when copying over to CUDA which really militates against duplication! |
lkdvos
reviewed
Oct 29, 2026
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
Really nice how much code duplication can go away!
lkdvos
reviewed
Oct 29, 2026
lkdvos
approved these changes
Oct 29, 2026
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
Up to minor remark looks good to me!
Member
Author
|
AMD queue is hella backed up and since this is a backend agnostic change, I'm going to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies things by using one kernel for the (anti)hermitian projections. It should cut down on the number of independent kernel launches compared to the CPU-side blocked version.